Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S-expression parsing example #955

Merged
merged 2 commits into from
Jun 16, 2019
Merged

Add S-expression parsing example #955

merged 2 commits into from
Jun 16, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Jun 5, 2019

resolves #952

Hello!

Thanks for taking the time to review this! Let me know if there are any changes I can make to improve this example -- I'm happy to make any changes.

examples/s_expression.rs Outdated Show resolved Hide resolved
examples/s_expression.rs Outdated Show resolved Hide resolved
examples/s_expression.rs Outdated Show resolved Hide resolved
@MarkMcCaskey
Copy link
Contributor Author

Great! Thank you for your feedback! I'm very surprised I had never seen map(Constructor) before -- that's very useful.

I've updated the example to reflect the changes you suggested!

@Geal
Copy link
Collaborator

Geal commented Jun 13, 2019

awesome! One last thing: you should add alloc as feature to the example like this: https://github.com/Geal/nom/blob/master/Cargo.toml#L154
Otherwise the no_std CI variant won't pass: https://travis-ci.org/Geal/nom/jobs/545411894

@MarkMcCaskey
Copy link
Contributor Author

Okay! I updated it to be like the JSON example and squashed the extra commits. Thanks for the guidance!

@MarkMcCaskey
Copy link
Contributor Author

It looks like the reason CI is failing now is unrelated to my changes

@Geal Geal merged commit 0425928 into rust-bakery:master Jun 16, 2019
@Geal
Copy link
Collaborator

Geal commented Jun 16, 2019

thank you for your help :)

@Geal Geal added this to the 5.0 milestone Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request - simple lisp parsing example
2 participants