Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node startup time #78

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

terror
Copy link
Contributor

@terror terror commented Aug 1, 2022

We have many tests to run, node startup was really slow, these changes speed it up:

  • Move sleep to end of client creation loop and reduce it to 100ms
  • Don't create wallet by default

@RCasatta
Copy link
Collaborator

RCasatta commented Aug 3, 2022

It looks versions < 0.21 don't support this... And also I am afraid not creating the default wallet will break too much users code:

I would suggest:

  • A standalone PR with only the non-controversial "Move sleep to end of client creation loop and reduce it to 100ms" which I would merge right away
  • Another PR with a new configuration parameter like skip-default-wallet-creation, which is false by default so it keeps current behavior but that you can use in your tests to speed things up

@terror
Copy link
Contributor Author

terror commented Aug 5, 2022

It looks versions < 0.21 don't support this... And also I am afraid not creating the default wallet will break too much users code:

I would suggest:

  • A standalone PR with only the non-controversial "Move sleep to end of client creation loop and reduce it to 100ms" which I would merge right away
  • Another PR with a new configuration parameter like skip-default-wallet-creation, which is false by default so it keeps current behavior but that you can use in your tests to speed things up

I see, I didn't realize versions < 0.21 didn't support this. I'll modify this PR to include the changes you suggested!

@RCasatta
Copy link
Collaborator

There are still some issue in the CI, note I created a separated MR #83 for just the sleep thing (I think I am going to release a version soon, so I thought to include the easy part in the release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants