Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsonrpc to 0.14 #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

w0xlt
Copy link

@w0xlt w0xlt commented Jan 29, 2023

This PR updates jsonrpc to 0.14.
Reason: Apparently, apoelstra/rust-jsonrpc#67 was fixed by apoelstra/rust-jsonrpc#72, which was included in version 0.14.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d76f8db

@apoelstra
Copy link
Member

I'm a bit surprised that we didn't PR to do this sooner.

FYI the update to rust-jsonrpc caused some other issues: apoelstra/rust-jsonrpc#80 and apoelstra/rust-jsonrpc#79.

Our current plan is to try to move from rust-jsonrpc's ad-hoc HTTP client to minreq ... but that is stalled on minreq having a set of feature flags that don't all compile, and those which do have different MSRVs, and they don't have their intentions documented, and I haven't taken the time to exhaustively test everything.

@apoelstra
Copy link
Member

Will wait for somebody else to ACK this, and maybe have more discussion, before merging.

@tcharding
Copy link
Member

I think we want to jump to latest version v0.16.0?

RCasatta added a commit that referenced this pull request Nov 1, 2023
7053c8f Update MSRV to Rust 1.48.0 (Tobin C. Harding)

Pull request description:

  This would allow us to upgrade the `jsonrpc` dep and get `minreq` support possibly alleviating the need for #276. Also required to use the latest `rust-bitcoin`.

ACKs for top commit:
  RCasatta:
    utACK 7053c8f

Tree-SHA512: f3e25dfc2e61cab4666ab0be47406282fbdaabe614d98715377a16ff472d89f5678fb1a29613ca43cf9b671194b21af2b69c15d52ccd7dc26c0b8ac573b898a5
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d76f8db

@tcharding
Copy link
Member

Can we merge this? I"ll do a separate PR for upgrading further.

@traitmeta
Copy link

rust-jsonrpc has supported minreq in version v0.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants