Add "rand" feature #342
Merged
Add "rand" feature #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaces #193 |
tcharding
force-pushed
the
05-01-expose-rand
branch
from
d75c730
to
ef0f311
Compare
tcharding
force-pushed
the
05-01-expose-rand
branch
from
ef0f311
to
e20a116
Compare
tcharding
force-pushed
the
05-01-expose-rand
branch
2 times, most recently
from
827589b
to
ed2f931
Compare
Currently we activate the "bitcoin/rand-std" feature unconditionally in `json`. Some users may not wish to use the bitcoin "rand" feature. Add a "rand" feature to `json` and `client` and use it to activate "rand-std" in `bitcoin`. The crates currently have no features, this is the first. In order to be less of a breaking change also add a "default" feature and enable "rand" from "default".
tcharding
force-pushed
the
05-01-expose-rand
branch
from
ed2f931
to
af66cfe
Compare
apoelstra
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we activate the "bitcoin/rand-std" feature unconditionally in
json. Some users may not wish to use the bitcoin "rand" feature.Add a "rand" feature to
jsonandclientand use it to activate "rand-std" inbitcoin.The crates currently have no features, this is the first. In order to be less of a breaking change also add a "default" feature and enable "rand" from "default".