New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a C compiler warning because of redefinition of SECP256K1_BUILD #318

Merged

apoelstra merged 1 commit into rust-bitcoin:master from elichai:secp_build_warn

Jul 1, 2021

Member

elichai commented Jun 30, 2021

The warning:

warning: depend/secp256k1/src/secp256k1.c:7:9: warning: 'SECP256K1_BUILD' macro redefined [-Wmacro-redefined]
warning: #define SECP256K1_BUILD
warning:         ^
warning: <command line>:1:9: note: previous definition is here
warning: #define SECP256K1_BUILD 1
warning:         ^
warning: 1 warning generated.

The flag was first added in: #35 But it is no longer needed since: bitcoin-core/secp256k1#928


          Remove SECP256K1_BUILD as its no longer needed

70847e6

real-or-random approved these changes

View reviewed changes

apoelstra approved these changes

View reviewed changes

Member

apoelstra left a comment

utack. That's what I get for approving libsecp updates without looking at what's in them!

apoelstra merged commit 12e3c66 into rust-bitcoin:master

elichai deleted the secp_build_warn branch

July 4, 2021 07:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet