Debug traits for structs #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
reviewed
Aug 27, 2017
| @@ -459,6 +460,19 @@ impl Log for Logger { | |||
| fn flush(&self) {} | |||
| } | |||
|
|
|||
| impl fmt::Debug for Logger{ | |||
There was a problem hiding this comment.
There are some nice helper methods on Formatter that can make this easier. So you could have something like:
f.debug_struct("Logger")
.field("directives", &self.directives)
.field("filter", &self.filter)
.field("target", &self.target)
.finish()| @@ -4,6 +4,7 @@ use std::fmt; | |||
|
|
|||
| use self::regex::Regex; | |||
|
|
|||
| #[derive(Debug)] | |||
There was a problem hiding this comment.
Do we want the debug representation to display the values of these private internal fields? Right now this will output the debug value of the inner: Regex field. We may well want that, but I think it's worth making that decision explicit. Are you ok with this @sebasmagri?
There was a problem hiding this comment.
Any comments on this ?
There was a problem hiding this comment.
I think this is ok. Let's merge this in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14