Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Replace atty with is_terminal #248

Merged
merged 4 commits into from
Nov 24, 2022
Merged

fix!: Replace atty with is_terminal #248

merged 4 commits into from
Nov 24, 2022

Conversation

epage
Copy link
Contributor

@epage epage commented Nov 24, 2022

This is to get around a soundness issue.

As part of this, the MSRV was bumped to 1.60

BREAKING CHANGES: Features renamed

  • termcolor -> color
  • atty -> auto-color

This is over 6 months old and allows us to hide optional dependencies as
features so we can change them without breaking compatibility (after the
first time).
This makes it easier to change dependencies in the future.

BREAKING CHANGE: `termcolor` -> `color` and `atty` -> `auto-color`
@epage epage merged commit 4c37917 into rust-cli:main Nov 24, 2022
@epage epage deleted the atty branch November 24, 2022 17:53
g0hl1n added a commit to g0hl1n/mio-serial that referenced this pull request Dec 13, 2022
This is needed as env_logger v0.10.0 raised its MSRV to 1.60.0. For more
information please see the corresponding commit or PR:
    rust-cli/env_logger@660cf7f
    rust-cli/env_logger#248

Signed-off-by: Richard Leitner <dev@g0hl1n.net>
g0hl1n added a commit to g0hl1n/mio-serial that referenced this pull request Jan 13, 2023
This is needed as env_logger v0.10.0 raised its MSRV to 1.60.0. For more
information please see the corresponding commit or PR:
    rust-cli/env_logger@660cf7f
    rust-cli/env_logger#248

Signed-off-by: Richard Leitner <dev@g0hl1n.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant