Upgrade base to ubuntu 20.04 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The noninteractive env var had to be added since tzdata would try to ask for a region. ADDs changed to COPYs as it is good practice in the docker community. Also: - Remove fixed GCC_VER constraint (7.2.0 is not supported anymore) - Use rust musl make 0.9.9 (patch level update) - Use openssl 1.0.2u (patch level update)
Since there is clean up at each step, there is not much overhead, but it with debugging. Also: - Add LD=$TARGET-ld The HF targets seem to be happier with it. - Organize env vars and dedupe hardcoded paths
We need to add an CFLAGS env var for armv7-unknown-linux-musleabihf on docker run to make the compiler happy. Error was: ``` warning: cc1: error: '-mfloat-abi=hard': selected processor lacks an FPU ``` Can be fixed by using either of them: export CFLAGS_armv7_unknown_linux_musleabihf='-mfpu=vfpv3-d16' export CFLAGS_armv7_unknown_linux_musleabihf='-mfpu=neon' References: - influxdata/flux#3379 (comment) - https://wiki.debian.org/ArmHardFloatPort/VfpComparison#FPU Per documentation I use "vfpv3-d16" for the CI step. In the end the user this cross compiler tool needs to make the appropriate decision in their projects.
On GitHub workflows this seems to be unreliable sometimes, it randomly fails for some targets.
|
Thank you! |
dani-garcia
added a commit
to dani-garcia/vaultwarden
that referenced
this pull request
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The noninteractive env var had to be added since tzdata would try to ask for a region.
ADDs changed to COPYs as it is good practice in the docker community.
Also:
General compile erros for 32 bit ARMs
See the issues and discussion here:
time_tdefinition on 32-bit targets according to "time64" rust-lang/libc#1848HF targets
We need to add an CFLAGS env var for armv7-unknown-linux-musleabihf on
docker run to make the compiler happy.
Error was:
Can be fixed by using either of them:
References:
Per documentation I use
vfpv3-d16for the CI step here (labeled as the most common denominator).In the end the user of this cross compiler tool needs to make the appropriate decision in their projects.