This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
Perform some housekeeping #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanewok
commented
Oct 5, 2017
| @@ -446,7 +446,7 @@ impl<L: AnalysisLoader> AnalysisHost<L> { | |||
| }) | |||
| } | |||
|
|
|||
| // e.g., https://github.com/rust-lang/rust/blob/master/src/libcollections/string.rs#L261-L263 | |||
| // e.g., https://github.com/rust-lang/rust/blob/master/src/liballoc/string.rs#L261-L263 | |||
There was a problem hiding this comment.
Changed, since the previous link was invalid
Xanewok
commented
Oct 5, 2017
| }, | ||
| // A crate we've never seen before. | ||
| None => { | ||
| // We have fresher data than what we can read. |
There was a problem hiding this comment.
Wanted to get rid of defining the same block twice for two cases, is this okay?
Xanewok
commented
Oct 5, 2017
| let mut buf = String::new(); | ||
| file.read_to_string(&mut buf).unwrap(); | ||
|
|
||
| let buf = read_file_contents(path).or_else(|err| { |
There was a problem hiding this comment.
Separated into read_file_contents to catch a possible error and report it, however if we were to ignore warning about the error, this could be further simplified with ok()?s - should I change that?
There was a problem hiding this comment.
Nah, seems good to acknowledge the error
Xanewok
commented
Oct 5, 2017
| @@ -6,21 +6,17 @@ | |||
| // option. This file may not be copied, modified, or distributed | |||
| // except according to those terms. | |||
|
|
|||
| macro_rules! option_try( | |||
There was a problem hiding this comment.
impl Try for Option has landed! 🎉
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.