Exposing diplomat-tool through a library
#348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2023
|
I'd rather not commit to an API here just yet; especially since a thing I definitely want to do is give backends the ability to accept parameters. |
|
It's pre-1.0 so personally I don't have a huge concern with making a starter API |
Manishearth
reviewed
Oct 20, 2023
|
|
||
| pub fn gen( | ||
| entry: &Path, | ||
| target_language: &str, |
There was a problem hiding this comment.
at the very least I think we should have a config struct or something that encapsulates all this
There was a problem hiding this comment.
we should also perhaps have a CLI feature
|
Hm, fair. I do think we should spend some effort cleaning up the API though |
|
There's a lot to clean up in Diplomat. One thing I noticed is that the language gets passed around everywhere as a |
Manishearth
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients like ICU4X need to version
diplomat-toolalong with the other diplomat crates. Cargo cannot at the moment version binaries, exposing a library is the recommended workaround (rust-lang/cargo#2267).