-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation requires PwmPin<Duty=u16> but any Duty value would work #8
Comments
i remember ending in generics hell when i tried this (but also didn't invest a lot of time, either). but if you get it to work feel free to provide a PR! please note that with e-h 1.0 this will be a lot cleaner, see rust-embedded/embedded-hal#430 |
rursprung
added a commit
that referenced
this issue
Jul 2, 2023
as this version of embedded-hal has added `SetDutyCycle` as the equivalent / successor of the old `PwmPin` support for it can now be added here. open points: * wait for a release of stm32f4xx-hal which includes the `SetDutyCycle` implementation (PR already merged) * wait for a release of embedded-hal-mock which includes the `SetDutyCycle` implementation (PR currently open) fixes #3 fixes #8
rursprung
added a commit
that referenced
this issue
Jul 6, 2023
as this version of embedded-hal has added `SetDutyCycle` as the equivalent / successor of the old `PwmPin` support for it can now be added here. open points: * wait for a release of stm32f4xx-hal which includes the `SetDutyCycle` implementation (PR already merged) * wait for a release of embedded-hal-mock which includes the `SetDutyCycle` implementation (PR currently open) fixes #3 fixes #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We can generalize further by only changing a few lines of code I believe:
The text was updated successfully, but these errors were encountered: