Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #164

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Update index.md #164

merged 1 commit into from
Apr 26, 2020

Conversation

flip111
Copy link
Contributor

@flip111 flip111 commented Feb 17, 2019

@flip111 flip111 requested a review from a team as a code owner February 17, 2019 21:37
@rust-highfive
Copy link

r? @thejpster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Feb 17, 2019
@adamgreig
Copy link
Member

My preference is to not change this, but if we do I'd rather reword it to flow better. Something like:

This solves our immediate problem, but we're still left writing a lot of unsafe code which we need to carefully reason about, and we might be using critical sections needlessly. Since each critical section temporarily pauses interrupt processing, there is an associated cost of some extra code size and higher interrupt latency and jitter (interrupts may take longer to be processed, and the time until they are processed will be more variable). Whether this is a problem depends on your system, but in general we'd like to avoid it.

@Disasm Disasm added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2019
@jamesmunns jamesmunns mentioned this pull request Apr 26, 2020
bors bot added a commit that referenced this pull request Apr 26, 2020
233: Flip111/patch 8 r=adamgreig a=jamesmunns

Supersedes #164

Co-authored-by: flip111 <flip101@gmail.com>
Co-authored-by: James Munns <james.munns@ferrous-systems.com>
@bors bors bot merged commit 14cb845 into rust-embedded:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants