Fix impl Gpio -> impl GpioConfig
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the two sections "Peripherals as State Machines" and "Design Contracts" of the "Static Guarantees" chapter, `impl Gpio` was incorrectly used in place of `impl GpioConfig` at one place in each section. This commit fixes that.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @andre-richter (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
bors bot
added a commit
that referenced
this pull request
Dec 7, 2019
216: Fix `impl Gpio` -> `impl GpioConfig` r=andre-richter a=andebjor In the two sections "Peripherals as State Machines" and "Design Contracts" of the "Static Guarantees" chapter, `impl Gpio` was incorrectly used in place of `impl GpioConfig` at one place in each section. Co-authored-by: Björn Andersson <andebjor@gmail.com>
Build succeeded |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 15, 2019
Update cargo, books Update nomicon, cargo, reference, book, rust-by-example, embedded-book ## nomicon 2 commits in 041c46e692a2592853aeca132c8dfe8eb5a79a9e..8be35b201f9cf0a4c3fcc96c83ac21671dcf3112 2019-11-20 16:46:45 +0100 to 2019-12-01 13:02:12 -0500 - Update unwinding.md - ci: remove needless rust-docs component ## cargo 15 commits in 626f0f40efd32e6b3dbade50cd53fdfaa08446ba..5a139f7e6d67fd8a416a3f19d8e01581d24c0333 2019-12-03 16:53:04 +0000 to 2019-12-10 20:17:50 +0000 - Bump cargo-platform version. (rust-lang/cargo#7693) - Add a test for `cargo locate-project` (rust-lang/cargo#7690) - Emit error on [target.'cfg(debug_assertions)'.dependencies] and similar (rust-lang/cargo#7660) - Update the layout of `Cargo Commands` in doc (rust-lang/cargo#7687) - Features and dependencies can't have the same name (rust-lang/cargo#7682) - Fix some typos in doc (rust-lang/cargo#7672) - Add test for `NAME` environment variable when `cargo new` (rust-lang/cargo#7667) - Add test for `GIT_COMMITTER_EMAIL` when `cargo new` (rust-lang/cargo#7666) - document support for Bitbucket Pipelines badges (rust-lang/cargo#7663) - Add cargo-vendor to the list of cargo commands in doc (rust-lang/cargo#7659) - Fix typo in section 'Caching the Cargo home in CI' (rust-lang/cargo#7661) - Docs: Add an appendix on git authentication. (rust-lang/cargo#7658) - Remove --offline empty index error. (rust-lang/cargo#7655) - Change the link destination of cargo book contribution (rust-lang/cargo#7657) - Add a --offline hint. (rust-lang/cargo#7654) ## reference 2 commits in 9e843ae..787e8d8 2019-11-24 17:44:04 +0100 to 2019-12-10 10:01:29 -0800 - Update for visibility syntax changes. (rust-lang/reference#722) - document `bind_by_move_pattern_guards` (rust-lang/reference#720) ## book 2 commits in 81ebaa2a3f88d4d106516c489682e64cacba4f60..ef8bb568035ded8ddfa30a9309026638cc3c8136 2019-11-15 08:30:04 -0800 to 2019-11-28 11:00:04 -0600 - Remove optional commas from match arms in ch18-03 (rust-lang/book#2176) - Remove call_box() from ch20-03 (rust-lang/book#2177) ## rust-by-example 1 commits in 4835e025826729827a94fdeb7cb85fed288d08bb..b7ac1bc76b7d02a43c83b3a931d226f708aa1ff4 2019-11-14 09:20:43 -0300 to 2019-12-02 11:38:43 -0300 - Make TryFrom & TryInto example editable (rust-lang/rust-by-example#1297) ## embedded-book 1 commits in 5ca585c4a7552efb546e7681c3de0712f4ae4fdc..c26234930282210849256e4ecab925f0f2daf3be 2019-08-27 13:39:14 +0000 to 2019-12-07 17:25:11 +0000 - Fix `impl Gpio` -> `impl GpioConfig` (rust-embedded/book#216)
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 15, 2019
Update cargo, books Update nomicon, cargo, reference, book, rust-by-example, embedded-book ## nomicon 2 commits in 041c46e692a2592853aeca132c8dfe8eb5a79a9e..8be35b201f9cf0a4c3fcc96c83ac21671dcf3112 2019-11-20 16:46:45 +0100 to 2019-12-01 13:02:12 -0500 - Update unwinding.md - ci: remove needless rust-docs component ## cargo 15 commits in 626f0f40efd32e6b3dbade50cd53fdfaa08446ba..5a139f7e6d67fd8a416a3f19d8e01581d24c0333 2019-12-03 16:53:04 +0000 to 2019-12-10 20:17:50 +0000 - Bump cargo-platform version. (rust-lang/cargo#7693) - Add a test for `cargo locate-project` (rust-lang/cargo#7690) - Emit error on [target.'cfg(debug_assertions)'.dependencies] and similar (rust-lang/cargo#7660) - Update the layout of `Cargo Commands` in doc (rust-lang/cargo#7687) - Features and dependencies can't have the same name (rust-lang/cargo#7682) - Fix some typos in doc (rust-lang/cargo#7672) - Add test for `NAME` environment variable when `cargo new` (rust-lang/cargo#7667) - Add test for `GIT_COMMITTER_EMAIL` when `cargo new` (rust-lang/cargo#7666) - document support for Bitbucket Pipelines badges (rust-lang/cargo#7663) - Add cargo-vendor to the list of cargo commands in doc (rust-lang/cargo#7659) - Fix typo in section 'Caching the Cargo home in CI' (rust-lang/cargo#7661) - Docs: Add an appendix on git authentication. (rust-lang/cargo#7658) - Remove --offline empty index error. (rust-lang/cargo#7655) - Change the link destination of cargo book contribution (rust-lang/cargo#7657) - Add a --offline hint. (rust-lang/cargo#7654) ## reference 2 commits in 9e843ae..787e8d8 2019-11-24 17:44:04 +0100 to 2019-12-10 10:01:29 -0800 - Update for visibility syntax changes. (rust-lang/reference#722) - document `bind_by_move_pattern_guards` (rust-lang/reference#720) ## book 2 commits in 81ebaa2a3f88d4d106516c489682e64cacba4f60..ef8bb568035ded8ddfa30a9309026638cc3c8136 2019-11-15 08:30:04 -0800 to 2019-11-28 11:00:04 -0600 - Remove optional commas from match arms in ch18-03 (rust-lang/book#2176) - Remove call_box() from ch20-03 (rust-lang/book#2177) ## rust-by-example 1 commits in 4835e025826729827a94fdeb7cb85fed288d08bb..b7ac1bc76b7d02a43c83b3a931d226f708aa1ff4 2019-11-14 09:20:43 -0300 to 2019-12-02 11:38:43 -0300 - Make TryFrom & TryInto example editable (rust-lang/rust-by-example#1297) ## embedded-book 1 commits in 5ca585c4a7552efb546e7681c3de0712f4ae4fdc..c26234930282210849256e4ecab925f0f2daf3be 2019-08-27 13:39:14 +0000 to 2019-12-07 17:25:11 +0000 - Fix `impl Gpio` -> `impl GpioConfig` (rust-embedded/book#216)
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Dec 21, 2019
Update cargo, books Update nomicon, cargo, reference, book, rust-by-example, embedded-book ## nomicon 2 commits in 041c46e692a2592853aeca132c8dfe8eb5a79a9e..8be35b201f9cf0a4c3fcc96c83ac21671dcf3112 2019-11-20 16:46:45 +0100 to 2019-12-01 13:02:12 -0500 - Update unwinding.md - ci: remove needless rust-docs component ## cargo 15 commits in 626f0f40efd32e6b3dbade50cd53fdfaa08446ba..5a139f7e6d67fd8a416a3f19d8e01581d24c0333 2019-12-03 16:53:04 +0000 to 2019-12-10 20:17:50 +0000 - Bump cargo-platform version. (rust-lang/cargo#7693) - Add a test for `cargo locate-project` (rust-lang/cargo#7690) - Emit error on [target.'cfg(debug_assertions)'.dependencies] and similar (rust-lang/cargo#7660) - Update the layout of `Cargo Commands` in doc (rust-lang/cargo#7687) - Features and dependencies can't have the same name (rust-lang/cargo#7682) - Fix some typos in doc (rust-lang/cargo#7672) - Add test for `NAME` environment variable when `cargo new` (rust-lang/cargo#7667) - Add test for `GIT_COMMITTER_EMAIL` when `cargo new` (rust-lang/cargo#7666) - document support for Bitbucket Pipelines badges (rust-lang/cargo#7663) - Add cargo-vendor to the list of cargo commands in doc (rust-lang/cargo#7659) - Fix typo in section 'Caching the Cargo home in CI' (rust-lang/cargo#7661) - Docs: Add an appendix on git authentication. (rust-lang/cargo#7658) - Remove --offline empty index error. (rust-lang/cargo#7655) - Change the link destination of cargo book contribution (rust-lang/cargo#7657) - Add a --offline hint. (rust-lang/cargo#7654) ## reference 2 commits in 9e843ae..787e8d8 2019-11-24 17:44:04 +0100 to 2019-12-10 10:01:29 -0800 - Update for visibility syntax changes. (rust-lang/reference#722) - document `bind_by_move_pattern_guards` (rust-lang/reference#720) ## book 2 commits in 81ebaa2a3f88d4d106516c489682e64cacba4f60..ef8bb568035ded8ddfa30a9309026638cc3c8136 2019-11-15 08:30:04 -0800 to 2019-11-28 11:00:04 -0600 - Remove optional commas from match arms in ch18-03 (rust-lang/book#2176) - Remove call_box() from ch20-03 (rust-lang/book#2177) ## rust-by-example 1 commits in 4835e025826729827a94fdeb7cb85fed288d08bb..b7ac1bc76b7d02a43c83b3a931d226f708aa1ff4 2019-11-14 09:20:43 -0300 to 2019-12-02 11:38:43 -0300 - Make TryFrom & TryInto example editable (rust-lang/rust-by-example#1297) ## embedded-book 1 commits in 5ca585c4a7552efb546e7681c3de0712f4ae4fdc..c26234930282210849256e4ecab925f0f2daf3be 2019-08-27 13:39:14 +0000 to 2019-12-07 17:25:11 +0000 - Fix `impl Gpio` -> `impl GpioConfig` (rust-embedded/book#216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the two sections "Peripherals as State Machines" and "Design
Contracts" of the "Static Guarantees" chapter,
impl Gpiowasincorrectly used in place of
impl GpioConfigat one place in eachsection.