Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add target on toolchain install #152

Merged
merged 1 commit into from
Oct 17, 2024
Merged

add target on toolchain install #152

merged 1 commit into from
Oct 17, 2024

Conversation

Emilgardis
Copy link
Member

resolves #151

@Emilgardis Emilgardis requested a review from a team as a code owner October 16, 2024 20:23
@jannic
Copy link
Member

jannic commented Oct 16, 2024

The target specification was lost in commit f16328a. There was no new release after merging that, which is why the broken release pipeline wasn't noticed earlier.

The same commit removed the target specification from the cache key (f16328a#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L31). I'm not familiar with that cache, but reading Swatinem/rust-cache#203 I get the impression that it's indeed important to have the target in the cache key.

@burrbull burrbull added this pull request to the merge queue Oct 17, 2024
Merged via the queue into master with commit a0a89ba Oct 17, 2024
8 checks passed
@burrbull burrbull deleted the fix-aarch64-darwin branch October 17, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release CI is broken
3 participants