Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust-cov / cargo-cov for llvm-cov #97

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Add rust-cov / cargo-cov for llvm-cov #97

merged 3 commits into from
Nov 17, 2020

Conversation

richkadel
Copy link
Contributor

Rust now includes llvm-cov, which is used in combination with
llvm-profdata to generate coverage reports from the .profraw files
now generated by Rust binaries compiled with -Z instrument-coverage.

@richkadel
Add rust-cov / cargo-cov for llvm-cov
527f62b 
Rust now includes `llvm-cov`, which is used in combination with
`llvm-profdata` to generate coverage reports from the `.profraw` files
now generated by Rust binaries compiled with `-Z instrument-coverage`.
@richkadel richkadel requested a review from a team as a code owner November 17, 2020 21:13
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @reitermarkus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

therealprof
therealprof requested changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

Would you minding adding an entry to CHANGELOG.md?

@therealprof
Copy link
Contributor

Could also use a usage example for the README but that is optional. 😅

@richkadel
Copy link
Contributor Author

@therealprof

I realized I need to update the crate version, and yes, added a CHANGELOG entry.

Hope it's OK if I don't update README for now?

No pressure, but just wondering, when might you be able to push this update to crates.io? (I'm updating related documentation.)

Thanks!

@therealprof
Copy link
Contributor

Aggressively pushing for a release. I like your style. 😬

therealprof
therealprof previously approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

bors bot added a commit that referenced this pull request Nov 17, 2020
@bors @richkadel
Merge #97
cc2f836 
97: Add rust-cov / cargo-cov for llvm-cov r=therealprof a=richkadel

Rust now includes `llvm-cov`, which is used in combination with
`llvm-profdata` to generate coverage reports from the `.profraw` files
now generated by Rust binaries compiled with `-Z instrument-coverage`.

Co-authored-by: Rich Kadel <richkadel@google.com>
@therealprof
Copy link
Contributor

bors r-

@bors
Copy link
Contributor

bors bot commented Nov 17, 2020

Canceled.

therealprof
therealprof reviewed Nov 17, 2020
View reviewed changes
CHANGELOG.md
@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [v0.3.3] - 2020-11-17
Copy link
Contributor

@therealprof therealprof Nov 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the v0.3.3 change link at the bottom of the CHANGELOG.md for the release.

Sorry for missing that earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, didn't see that, but I'll fix it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

therealprof
therealprof reviewed Nov 17, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
therealprof
therealprof approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see whether I can still approve after the edit.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 17, 2020

Build succeeded:

@bors bors bot merged commit 115e26e into rust-embedded:master Nov 17, 2020
@therealprof
Copy link
Contributor

https://crates.io/crates/cargo-binutils

Released. 🎉

@richkadel
Copy link
Contributor Author

woohoo! It already works for me after re-running cargo install cargo-binutils!

Thanks for the really fast response!

@burrbull burrbull mentioned this pull request Nov 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@reitermarkus reitermarkus

Labels
S-waiting-on-review T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richkadel @rust-highfive @therealprof @reitermarkus