Align sections

[NickeZ]

Hey, I had the same issue as in #189. Don't ask me why this works I looked at other linker scripts.

Fixes #189

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @korken89 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[thejpster]

I'll see if I can create a reproducer for #189 and test this out later today.

[therealprof]

The change looks good to me but I'm really curious why this is necessary. Maybe some crappy/picky linkers in play?

[NickeZ]

I saw this technique in the template linker scripts you get from microchip (atmel). You can see an example here: https://github.com/digitalbitbox/mcu/blob/master/bootloader.ld

I'm not using any strange linker, it is GCC 8.

https://developer.arm.com/-/media/Files/downloads/gnu-rm/8-2018q4/gcc-arm-none-eabi-8-2018-q4-major-linux.tar.bz2?revision=d830f9dd-cd4f-406d-8672-cca9210dd220?product=GNU%20Arm%20Embedded%20Toolchain,64-bit,,Linux,8-2018-q4-major

[lthiery]

This fixed my issue. I don't understand it either, but it works 👍

[korken89]

I had a look at the ChibiOS linker implementation, which also does this trick. It seems as the first align should be enough, but multiple sources double do it. I was also not able to reproduce though.
Feels like some linker trickery, but adding this should not alter the original intention so I will accept this.

[korken89]

bors r+

[bors]

Build succeeded

• continuous-integration/travis-ci/push