Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make const-fn default #153

Closed
adamgreig opened this issue Jul 9, 2019 · 1 comment · Fixed by #159
Closed

Make const-fn default #153

adamgreig opened this issue Jul 9, 2019 · 1 comment · Fixed by #159

Comments

@adamgreig
Copy link
Member

At the moment the cortex-m still hides const versions of some functions (especially Mutex::new()) behind the const-fn feature, but these have worked on stable Rust for some time now.

It looks like this crate does not yet follow the WG MSRV policy so I'm not really sure what the MSRV even is, but perhaps we could allow it to be 1.31 and therefore either remove the const-fn feature or make it a default.

cc rust-embedded/book#196
@Disasm
Copy link
Member

Disasm commented Jul 9, 2019

I filed a PR to bare-metal with this fix: rust-embedded/bare-metal#18

@geomatsi geomatsi mentioned this issue Jul 10, 2019
Closed
@adamgreig adamgreig mentioned this issue Jul 24, 2019
Merged
bors bot added a commit that referenced this issue Jul 28, 2019
@bors @adamgreig
Merge #159
6a21391 
159: Define MSRV to be 1.31.0 and unconditionally use const-fn r=therealprof a=adamgreig

As per https://github.com/rust-embedded/wg/blob/master/ops/msrv.md we should have a defined MSRV for this crate. This PR proposes setting it to 1.31 to allow use of `const-fn` from bare-metal by default, and updates `Cargo.toml` accordingly. It also sets the edition to 2018, permitted by an MSRV of 1.31.

Since this PR _introduces_ an MSRV I propose it not requiring a semver bump, and we instead would look to release this change as `0.6.1`.

Closes #153.

Co-authored-by: Adam Greig <adam@ael.co.uk>
Co-authored-by: Adam Greig <adam@adamgreig.com>
@bors bors bot closed this as completed in #159 Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define MSRV to be 1.31.0 and unconditionally use const-fn rust-embedded/cortex-m
2 participants
@adamgreig @Disasm