Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add symtab (size info) for all external assembly functions #212

Merged
merged 3 commits into from
May 5, 2020
Merged

Add symtab (size info) for all external assembly functions #212

merged 3 commits into from
May 5, 2020

Conversation

stianeklund
Copy link
Contributor

Adds .size info for all of the external assembly functions.
Fixes #211

@stianeklund stianeklund requested a review from a team as a code owner April 28, 2020 21:35
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @korken89 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Apr 28, 2020
@jonas-schievink
Copy link
Contributor

Don't these have to go after the implementation? They use ., which refers to the current address.

@stianeklund
Copy link
Contributor Author

Don't these have to go after the implementation? They use ., which refers to the current address.
@jonas-schievink Yeah I think you're right. I've made the changes.

japaric
japaric previously approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

(a member of the cortex-m team needs to bors this)

jonas-schievink
jonas-schievink previously approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r=japaric

bors bot added a commit that referenced this pull request Apr 29, 2020
@bors @stianeklund
Merge #212
96a091b 
212: Add symtab (size info) for all external assembly functions r=japaric a=stianeklund

Adds `.size` info for all of the external assembly functions. 
Fixes #211

Co-authored-by: Stian Eklund <stian.eklund@gmail.com>
@jonas-schievink
Copy link
Contributor

bors r-

CI broke

@bors
Copy link
Contributor

bors bot commented Apr 29, 2020

Canceled.

@japaric
Copy link
Member

japaric commented May 4, 2020

Most of the CI errors should be fixed by #210 so this PR is blocked on that one.

This CI error makes sense no sense to me though: https://travis-ci.org/github/rust-embedded/cortex-m/jobs/680770633

+diff -u bin/thumbv6m-none-eabi.after bin/thumbv6m-none-eabi.before
--- bin/thumbv6m-none-eabi.after	2020-04-28 22:06:50.010978643 +0000
+++ bin/thumbv6m-none-eabi.before	2020-04-28 22:06:49.911028639 +0000
@@ -1,6 +1,6 @@
 In archive bin/thumbv6m-none-eabi.a:
-cortex-m.o:     file format elf32-littlearm
+$crate.o:     file format elf32-littlearm
 Disassembly of section .text.__bkpt:

Why is there a $crate.o in the output? Did the variable expansion in assemble.sh fail somehow?

@jonas-schievink
Copy link
Contributor

@japaric I think that was some weirdness with Travis' bash version, it should be fixed now

@jonas-schievink
Copy link
Contributor

@stianeklund please rebase on master and rebuild the archives, then we can land this

@stianeklund stianeklund dismissed stale reviews from jonas-schievink and japaric via 4e58be2 May 5, 2020 19:18
jonas-schievink
jonas-schievink approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r=japaric

@bors
Copy link
Contributor

bors bot commented May 5, 2020

Build succeeded:

@bors bors bot merged commit 7494435 into rust-embedded:master May 5, 2020
@stianeklund stianeklund deleted the symtab branch May 6, 2020 05:57
@japaric japaric mentioned this pull request May 19, 2020
Closed
jonas-schievink pushed a commit that referenced this pull request Jul 19, 2020
@stianeklund @jonas-schievink
Bring blobs up to date fixing merge conflict
31e5bbe 
Fixes merge conflict between #210 & #212
@japaric japaric mentioned this pull request Sep 4, 2020
Merged
bors bot added a commit to rust-embedded/cortex-m-rt that referenced this pull request Sep 7, 2020
@bors @japaric
Merge #294
046c8f5 
294: add CFI and size info r=jonas-schievink a=japaric

like it was done in rust-embedded/cortex-m#216 and rust-embedded/cortex-m#212

Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
adamgreig pushed a commit that referenced this pull request Jan 12, 2022
@bors @jonas-schievink
Merge #205
3445f11 
205: Stop using randomized symbol names r=therealprof a=jonas-schievink

It isn't possible to do this by incrementing a global counter, since the expansion order of macros isn't guaranteed and might change between compiler invocations.

Fixes #212
Closes rust-embedded/cortex-m-rt#196
Closes rust-embedded/cortex-m-rt#195

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
adamgreig pushed a commit that referenced this pull request Jan 12, 2022
@bors @japaric
Merge #294
109a832 
294: add CFI and size info r=jonas-schievink a=japaric

like it was done in #216 and #212

Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink approved these changes

@japaric japaric japaric approved these changes

Assignees

@korken89 korken89

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add (.symtab) size info to external assembly functions
5 participants
@stianeklund @rust-highfive @jonas-schievink @japaric @korken89