Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installing dateutil since it is now a dependency of the GHP import script #298

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Feb 8, 2021

This would at least make our publication step work again even though still on Travis CI.
See #289

@eldruin eldruin requested a review from a team as a code owner February 8, 2021 10:51
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Feb 8, 2021
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 8, 2021

Build succeeded:

@bors bors bot merged commit 79ed05f into rust-embedded:master Feb 8, 2021
@eldruin eldruin deleted the add-dateutil-to-ci branch February 8, 2021 12:00
bors bot added a commit to rust-embedded/showcase that referenced this pull request Mar 3, 2021
24: Install dateutil which is required by ghp-import r=therealprof a=adamgreig

Same deal as rust-embedded/discovery#298

Co-authored-by: Adam Greig <adam@adamgreig.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants