Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-06-hello-world #299

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

winksaville
Copy link
Contributor

Converted lib.rs, Cargo.toml to use stm32f3_discovery.

.cargo/config:
I also, found that I would forget to to use --target when
building and running using cargo so set the default build target
to thumbv7em-none-eabihf

openocd.cfg:
Since the monitor lines are quite long and also easy to mistype or
forget to do I enhanced the file with the new lines and commented
on each of the lines.

README.md
Update to reflect the above changes.

@rust-highfive
Copy link

r? @jamesmunns

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Feb 9, 2021
Converted lib.rs, Cargo.toml to use stm32f3_discovery.

.cargo/config:
 I also, found that I would forget to to use `--target` when
 building and running using cargo so set the default build target
 to thumbv7em-none-eabihf

openocd.cfg:
 Since the monitor lines are quite long and also easy to mistype or
 forget to do I enhanced the file with the new lines and commented
 on each of the lines.

README.md
 Update to reflect the above changes.
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you! I just found one small nitpick.

src/06-hello-world/panic.md Outdated Show resolved Hide resolved
As suggested by @eldruin add backticks around ~/.gdbinit.
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for your work!

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 9, 2021

Build succeeded:

@bors bors bot merged commit 40a6309 into rust-embedded:master Feb 9, 2021
@winksaville winksaville deleted the New-06-hello-world branch February 10, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants