Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more specific chip spec for micro:bit v2 #427

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Use more specific chip spec for micro:bit v2 #427

merged 1 commit into from
Jan 3, 2022

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jan 3, 2022

Happy new year!

Fixes #425

@eldruin eldruin requested a review from a team as a code owner January 3, 2022 07:55
@rust-highfive
Copy link

r? @andre-richter

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Jan 3, 2022
adamgreig
adamgreig approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

bors merge

bors bot added a commit that referenced this pull request Jan 3, 2022
@bors @eldruin
Merge #427
463f9dd 
427: Use more specific chip spec for micro:bit v2 r=adamgreig a=eldruin

Happy new year!

Fixes #425

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build failed:

@adamgreig
Copy link
Member

Looks like the build failure is coming from a new 0.1.1 version of nrf-usbd which brings in critical-section, which depends on std when built for unix/windows, which brings in std's panic handler, which conflicts with panic_rtt_target/panic_halt from our own crates.

@adamgreig adamgreig mentioned this pull request Jan 3, 2022
Merged
bors bot added a commit that referenced this pull request Jan 3, 2022
@bors @adamgreig
Merge #428
c6fd3ab 
428: Run cargo-doc on relevant target instead of native r=eldruin a=adamgreig

Hopefully fixes CI build failure see in #427.

Co-authored-by: Adam Greig <adam@adamgreig.com>
@adamgreig
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build succeeded:

@bors bors bot merged commit 3b0bd96 into rust-embedded:master Jan 3, 2022
@eldruin eldruin deleted the microbit-v2-chip-spec branch January 3, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

@andre-richter andre-richter

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

specify more specific chip for micro:bit v2?
4 participants
@eldruin @rust-highfive @adamgreig @andre-richter