-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error types #150
Fix error types #150
Conversation
r? @therealprof (rust_highfive has picked a reviewer for you, use r? to override) |
What's our stated MSRV? |
@thejpster huh, looks like we haven't documented one in this repo yet? a few thoughts without particular direction:
|
@ryankurte As for me, |
Given our policy:
And that this only requires 1.34, I'm happy to merge this. Infallible will alias ! when it stabilises in 1.40, so we can take a PR to move to ! after 1.41 is out. |
@rust-embedded/hal any objections to merging? |
Let's do this. |
bors r+ |
Build failed |
Ah, the joy of requiring a funtioning nightly build. |
Cargo.lock is quite outdated, retrying |
Build succeeded |
PR |
core::convert::Infallible
was stabilized in 1.34.0. This PR replacesVoid
and()
error types withInfallible
.Note that this is a breaking change.