Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Capture, Pwm and Qei traits into modules #195

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Mar 16, 2020

The lib.rs file is already very long. I propose separating these traits which are just at the end of the file into their own modules.
I have kept the modules private and reexported the traits and types to maintain the same interface.
However, for consistency with the other traits maybe it would be worth it to expose these new modules as well and not reexport the traits in lib.rs.
What do you think?

@rust-highfive
Copy link

r? @ryankurte

(rust_highfive has picked a reviewer for you, use r? to override)

@ryankurte
Copy link
Contributor

Seems like a good idea to me!

However, for consistency with the other traits maybe it would be worth it to expose these new modules as well and not reexport the traits in lib.rs.

As part of the breaking changes happening in #192 I think we may as well fix this for consistency.

@eldruin
Copy link
Member Author

eldruin commented Mar 19, 2020

@ryankurte sorry there were some errors in the documentation. They should be solved now.
On macOS cross test --target=arm-unknown-linux-musleabihf does not run the doc tests. Any idea why?

@eldruin
Copy link
Member Author

eldruin commented Apr 2, 2020

Is anything preventing this being merged?

@ryankurte
Copy link
Contributor

thanks for the reminder, looks good to me (though we're going to need to do a lot of changelog updating)

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 2, 2020

Build succeeded

@bors bors bot merged commit adf7f9b into rust-embedded:master Apr 2, 2020
@eldruin eldruin deleted the separate-traits branch April 3, 2020 07:24
bors bot added a commit that referenced this pull request Apr 4, 2020
196: Document moved traits in changelog r=ryankurte a=eldruin

This was missing in #195.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants