-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Capture, Pwm and Qei traits into modules #195
Conversation
r? @ryankurte (rust_highfive has picked a reviewer for you, use r? to override) |
Seems like a good idea to me!
As part of the breaking changes happening in #192 I think we may as well fix this for consistency. |
f0bd024
to
60c9263
Compare
@ryankurte sorry there were some errors in the documentation. They should be solved now. |
Is anything preventing this being merged? |
thanks for the reminder, looks good to me (though we're going to need to do a lot of changelog updating) bors r+ |
Build succeeded |
The
lib.rs
file is already very long. I propose separating these traits which are just at the end of the file into their own modules.I have kept the modules private and reexported the traits and types to maintain the same interface.
However, for consistency with the other traits maybe it would be worth it to expose these new modules as well and not reexport the traits in
lib.rs
.What do you think?