Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nb 1.0 #234

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Use nb 1.0 #234

merged 1 commit into from
Jul 13, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jul 10, 2020

🎉

@eldruin eldruin requested review from ilya-epifanov and a team as code owners July 10, 2020 18:58
@rust-highfive
Copy link

r? @thejpster

(rust_highfive has picked a reviewer for you, use r? to override)

@ryankurte
Copy link
Contributor

🎉

is this worth an entry in the changelog? otherwise lgtm

@eldruin
Copy link
Member Author

eldruin commented Jul 13, 2020

Sure. I added an entry now.

ryankurte
ryankurte approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

bors r+

bors bot added a commit that referenced this pull request Jul 13, 2020
@bors @eldruin
Merge #234
8450b10 
234: Use nb 1.0 r=ryankurte a=eldruin

🎉 

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 13, 2020

Timed out.

@bors
Copy link
Contributor

bors bot commented Jul 13, 2020

Build succeeded:

@bors bors bot merged commit b46d300 into rust-embedded:master Jul 13, 2020
@eldruin eldruin deleted the use-nb-1.0 branch July 13, 2020 08:21
@eldruin eldruin mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankurte ryankurte ryankurte approved these changes

@ilya-epifanov ilya-epifanov Awaiting requested review from ilya-epifanov

Assignees

@thejpster thejpster

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eldruin @rust-highfive @ryankurte @thejpster