Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code formatting + check it on bors #266

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Mar 11, 2021

This was missed in #246.

@rust-highfive
Copy link

r? @ryankurte

(rust-highfive has picked a reviewer for you, use r? to override)

@eldruin
Copy link
Member Author

eldruin commented Mar 11, 2021

bors try

bors bot added a commit that referenced this pull request Mar 11, 2021
therealprof
therealprof previously approved these changes Mar 11, 2021
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bors r+

bors bot added a commit that referenced this pull request Mar 11, 2021
266: Fix code formatting + check it on bors r=therealprof a=eldruin

This was missed in #246.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@eldruin
Copy link
Member Author

eldruin commented Mar 11, 2021

bors r=therealprof

@bors
Copy link
Contributor

bors bot commented Mar 11, 2021

Already running a review

@bors
Copy link
Contributor

bors bot commented Mar 11, 2021

Timed out.

@bors
Copy link
Contributor

bors bot commented Mar 11, 2021

try

Timed out.

@eldruin
Copy link
Member Author

eldruin commented Mar 11, 2021

bors r=therealprof

bors bot added a commit that referenced this pull request Mar 11, 2021
266: Fix code formatting + check it on bors r=therealprof a=eldruin

This was missed in #246.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 11, 2021

Canceled.

@eldruin
Copy link
Member Author

eldruin commented Mar 11, 2021

bors try

bors bot added a commit that referenced this pull request Mar 11, 2021
@eldruin
Copy link
Member Author

eldruin commented Mar 12, 2021

bors try

@bors
Copy link
Contributor

bors bot commented Mar 12, 2021

try

Already running a review

@eldruin
Copy link
Member Author

eldruin commented Mar 12, 2021

bors try

@bors
Copy link
Contributor

bors bot commented Mar 12, 2021

try

Already running a review

@eldruin
Copy link
Member Author

eldruin commented Mar 12, 2021

Sorry for the back and forth. The bors requirements were not right.
Could you review this again @therealprof?

@bors
Copy link
Contributor

bors bot commented Mar 12, 2021

try

Timed out.

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

bors r+

@bors bors bot merged commit 4221894 into rust-embedded:master Mar 12, 2021
@therealprof
Copy link
Contributor

Just for reference: I'm not super keen on the idea of making formatting checks mandatory. We had problems in the past when formatting rules changed (similar to clippy rules) and we should actually run CI on a schedule and not just on PRs (which should be fine since they should be up-to-date re formatting).

Here's to hope that Rust is not going to make a lot of tweaks to the formatting to not get back at us. 😅 Let's see how it goes.

@eldruin
Copy link
Member Author

eldruin commented Mar 12, 2021

True. clippy bit me all over the place with a rule I believe is not good and I am still not even done updating all my drivers to disregard it. fmt has been quite stable so far, but yeah, good point.

@eldruin eldruin deleted the fix-formatting branch March 12, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants