-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code formatting + check it on bors #266
Conversation
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
bors try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
bors r+
bors r=therealprof |
Already running a review |
Timed out. |
tryTimed out. |
bors r=therealprof |
Canceled. |
bors try |
bors try |
tryAlready running a review |
bors try |
tryAlready running a review |
Sorry for the back and forth. The bors requirements were not right. |
tryTimed out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
bors r+
Just for reference: I'm not super keen on the idea of making formatting checks mandatory. We had problems in the past when formatting rules changed (similar to clippy rules) and we should actually run CI on a schedule and not just on PRs (which should be fine since they should be up-to-date re formatting). Here's to hope that Rust is not going to make a lot of tweaks to the formatting to not get back at us. 😅 Let's see how it goes. |
True. clippy bit me all over the place with a rule I believe is not good and I am still not even done updating all my drivers to disregard it. fmt has been quite stable so far, but yeah, good point. |
This was missed in #246.