Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark RNG traits as deprecated #271

Closed
wants to merge 3 commits into from

Conversation

jounathaen
Copy link

This is the softer approach than the nuclear option presented in #270 or at least the first step. Would also close #128 .

I'm not super sure about the removal of the traits from the prelude. This might break stuff. Alternatively an #[allow(deprecated)] for these imports would work.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eldruin eldruin added this to the v1.0.0 milestone Apr 27, 2021
@therealprof
Copy link
Contributor

Since we're in agreement to go with #270 I'm closing this.

@therealprof therealprof closed this May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] rand::RngCore for blocking RNG trait
5 participants