Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging with symbols #24

Merged
merged 8 commits into from
Sep 24, 2018
Merged

Logging with symbols #24

merged 8 commits into from
Sep 24, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented Sep 23, 2018

Obscure stuff with symbols; perfect fit for the nomicon, IMO.

r? @rust-embedded/resources (anyone)

@japaric japaric requested a review from a team as a code owner September 23, 2018 21:11
src/logging.md Outdated
@@ -0,0 +1,418 @@
# Logging with symbols

This section will show you how to exploit symbols and the ELF format to achieve
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, not a big fan of the word exploit. How about some more positive wording like utilise or (if fancy is desired) employ?

therealprof
therealprof previously approved these changes Sep 23, 2018
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@japaric japaric mentioned this pull request Sep 23, 2018
@japaric
Copy link
Member Author

japaric commented Sep 23, 2018

 Running `qemu-system-arm -cpu cortex-m3 -machine lm3s6965evb -nographic -semihosting-config enable=on,target=native -kernel target/thumbv7m-none-eabi/debug/app`

qemu-system-arm: -semihosting-config: invalid option

The old QEMU problem seen in rust-embedded/cortex-m-rt#128 strikes again. I'll see if I can get some binary release of a newer QEMU from somewhere.

@japaric
Copy link
Member Author

japaric commented Sep 23, 2018

install qemu from debian-sid?

didn't work ... We could use docker, I guess.

also note that the output of `cargo run` may not match what you get locally if
using a different toolchain
*sigh* we were only testing nightly before. Now we are testing beta and nightly
@japaric
Copy link
Member Author

japaric commented Sep 24, 2018

The build has been fixed and this needs a re-review.

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Sep 24, 2018
24: Logging with symbols r=therealprof a=japaric

Obscure stuff with symbols; perfect fit for the nomicon, IMO.

r? @rust-embedded/resources (anyone)

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Sep 24, 2018

Build succeeded

@bors bors bot merged commit 53d1567 into master Sep 24, 2018
@bors bors bot deleted the logging branch September 24, 2018 19:00
bors bot added a commit that referenced this pull request Sep 24, 2018
25: Global singletons r=therealprof a=japaric

This PR depends on #24

r? @rust-embedded/resources
@jamesmunns this is the global singleton pattern I mentioned some time ago on
IRC

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants