Added missing link to edition 2018 guide #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korken89
approved these changes
Nov 19, 2018
|
This looks good, but I'll wait to merge until we have a definitive answer on the move @jamesmunns can you perhaps shed some light on this? :) |
therealprof
approved these changes
Jan 31, 2019
|
bros r+ |
|
👊 |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 31, 2019
34: Added missing link to edition 2018 guide r=therealprof a=caemor It looked like the link to the edition guide was missing. But it might have been intentional because the edition guide might be moved to doc.rust-lang.org later on (rust-lang/edition-guide#76) :-) Co-authored-by: Chris <11088935+caemor@users.noreply.github.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looked like the link to the edition guide was missing. But it might have been intentional because the edition guide might be moved to doc.rust-lang.org later on (rust-lang/edition-guide#76) :-)