-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci #74
Fix ci #74
Conversation
Could I update MSRV to 1.65.0? (Because nix has updated it to 1.65.0) |
looks like we're still pulling in rust |
62fc591
to
06ee939
Compare
fixed |
Thank you! |
I mistakenly introduce some code only available in version 1.66.0 and above. I fixed it, let's give it another try, Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could you add an entry to the changelog about the MSRV change and remove the bors.toml file?
Done! |
Could you review it? @eldruin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
any idea? @eldruin |
No idea, all the checks pass. Somehow the merge queue seems not to receive the results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I have it now.
Could you replace the on:...
at the beginning of the ci.yml
with this?:
on:
push: # Run CI for all branches except GitHub merge queue tmp branches
branches-ignore:
- "gh-readonly-queue/**"
pull_request: # Run CI for PRs on any branch
merge_group: # Run CI for the GitHub merge queue
Done! @eldruin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, hopefully it works now. Thanks!
Close #73
Close #72
Update the ci target to allign with rust-lang.
because of rust-lang/compiler-team#648 , MIPS* target has been degreed to Tier3.
remove mips-unknown-linux-gnu
remove mips64-unknown-linux-gnuabi64
remove mips64el-unknown-linux-gnuabi64
remove mipsel-unknown-linux-gnu
add aarch64-unknown-linux-musl
add arm-unknown-linux-gnueabihf
add riscv64gc-unknown-linux-gnu