builder for AddressBlock #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Emilgardis |
Emilgardis
reviewed
Nov 9, 2021
svd-rs/src/addressblock.rs
Outdated
| /// | ||
| /// This doesn't do anything. | ||
| pub fn validate(&mut self, _lvl: ValidateLevel) -> Result<(), SvdError> { | ||
| // TODO |
There was a problem hiding this comment.
How is this a todo? What is there to do ?
There was a problem hiding this comment.
Yeah I don't think there's a reason for this note 😅
burrbull
force-pushed
the
address_block
branch
from
b6a3de1 to
b858a79
Compare
Emilgardis
reviewed
Nov 9, 2021
|
|
||
| /// An uniquely mapped address block to a peripheral | ||
| #[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))] | ||
| #[derive(Clone, Debug, PartialEq)] | ||
| #[non_exhaustive] |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.