Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.13 #187

Merged
merged 1 commit into from
Jan 4, 2022
Merged

v0.13 #187

merged 1 commit into from
Jan 4, 2022

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jan 2, 2022

No description provided.

@burrbull burrbull requested a review from a team as a code owner January 2, 2022 08:04
@thejpster
Copy link

Hmm. Looks OK, but I think I'd prefer to see the new example and the serialisation changes in a separate PR.

@burrbull
Copy link
Member Author

burrbull commented Jan 2, 2022

Hmm. Looks OK, but I think I'd prefer to see the new example and the serialisation changes in a separate PR.

#188

@burrbull burrbull marked this pull request as draft January 2, 2022 12:17
@burrbull burrbull marked this pull request as ready for review January 3, 2022 04:27
@burrbull
Copy link
Member Author

burrbull commented Jan 3, 2022

cc @rust-embedded/tools

@burrbull burrbull marked this pull request as draft January 3, 2022 08:00
thejpster
thejpster previously approved these changes Jan 3, 2022
View reviewed changes
@burrbull
Copy link
Member Author

burrbull commented Jan 4, 2022

Need to merge #192 first

@burrbull burrbull marked this pull request as ready for review January 4, 2022 15:19
adamgreig
adamgreig previously approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I noticed we don't have links in the changelog any more, but still use the [v0.13.0] style headers. Maybe worth adding links? They would have to be to the whole-repository but I guess it's OK.

@burrbull
Copy link
Member Author

burrbull commented Jan 4, 2022

LGTM. I noticed we don't have links in the changelog any more, but still use the [v0.13.0] style headers. Maybe worth adding links? They would have to be to the whole-repository but I guess it's OK.

Ok. I'll try to do this

adamgreig
adamgreig approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 4, 2022

Build succeeded:

@bors bors bot merged commit 23c628f into master Jan 4, 2022
@bors bors bot deleted the v0.13 branch January 4, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

@thejpster thejpster thejpster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @thejpster @adamgreig