nested derive #202
Merged
nested derive #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Emilgardis |
Emilgardis
requested changes
May 11, 2022
svd-parser/src/expand.rs
Outdated
| @@ -8,98 +8,152 @@ use svd_rs::{ | |||
| Device, EnumeratedValues, Field, Peripheral, Register, RegisterCluster, RegisterProperties, | |||
| }; | |||
|
|
|||
| #[derive(Clone, Debug, PartialEq, Hash, Eq)] | |||
| pub struct RPath { | |||
There was a problem hiding this comment.
I think it's ok to have these have a longer name
Suggested change
| pub struct RPath { | |
| pub struct RegisterPath { |
keeping it is fine too though, it may just be unclear for someone not familiar with how this works and looking here first time
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
svd-parser/src/expand.rs
Outdated
| } | ||
|
|
||
| #[derive(Clone, Debug, PartialEq, Hash, Eq)] | ||
| pub struct FPath { |
There was a problem hiding this comment.
Suggested change
| pub struct FPath { | |
| pub struct FieldPath { |
svd-parser/src/expand.rs
Outdated
| #[derive(Clone, Debug, PartialEq, Hash, Eq)] | ||
| pub struct FPath { | ||
| register: RPath, | ||
| field: String, |
There was a problem hiding this comment.
Suggested change
| field: String, | |
| ident: String, |
or
Suggested change
| field: String, | |
| name: String, |
|
Now it should look much cleaner |
|
cc @Emilgardis |
Emilgardis
approved these changes
May 12, 2022
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.