Make the schema field optional #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh, that didn't seem to trigger bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 18, 2018
63: Make the schema field optional r=Emilgardis a=jamesmunns Some devices that have created fake SVDs, such as for the MSP430, may not have schemas listed. This fixes the error seen with https://travis-ci.org/rust-embedded/svd2rust/jobs/456451847, See also rust-embedded/svd2rust#256 (comment) Co-authored-by: James Munns <james.munns@ferrous-systems.com>
Build failed |
Emilgardis
force-pushed
the
opt-schema
branch
from
9cc400a to
42903dd
Compare
bors bot
added a commit
that referenced
this pull request
Nov 18, 2018
63: Make the schema field optional r=Emilgardis a=jamesmunns Some devices that have created fake SVDs, such as for the MSP430, may not have schemas listed. This fixes the error seen with https://travis-ci.org/rust-embedded/svd2rust/jobs/456451847, See also rust-embedded/svd2rust#256 (comment) Co-authored-by: James Munns <james.munns@ferrous-systems.com>
Build failed |
bors bot
added a commit
that referenced
this pull request
Nov 18, 2018
63: Make the schema field optional r=Emilgardis a=jamesmunns Some devices that have created fake SVDs, such as for the MSP430, may not have schemas listed. This fixes the error seen with https://travis-ci.org/rust-embedded/svd2rust/jobs/456451847, See also rust-embedded/svd2rust#256 (comment) Co-authored-by: James Munns <james.munns@ferrous-systems.com>
Build failed |
Some devices that have created fake SVDs, such as for the MSP430, may not have schemas listed. Co-authored-by: =?UTF-8?q?Emil=20Gardstr=C3=B6m?= <emil.gardstrom@gmail.com>
Emilgardis
force-pushed
the
opt-schema
branch
from
42903dd to
10fca74
Compare
|
Ok, that was a bumpy road for a trivial change... My bad. bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 18, 2018
63: Make the schema field optional r=Emilgardis a=jamesmunns Some devices that have created fake SVDs, such as for the MSP430, may not have schemas listed. This fixes the error seen with https://travis-ci.org/rust-embedded/svd2rust/jobs/456451847, See also rust-embedded/svd2rust#256 (comment) Co-authored-by: James Munns <james.munns@ferrous-systems.com>
Build succeeded |
|
@Emilgardis thanks for the test cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices that have created fake SVDs, such as for the MSP430, may not have schemas listed.
This fixes the error seen with https://travis-ci.org/rust-embedded/svd2rust/jobs/456451847, See also rust-embedded/svd2rust#256 (comment)