Improve ci #221

Emilgardis · 2018-05-17T12:32:20Z

This pr includes

Support for the changes done in v0.13
--toolchain foo to specify what toolchain to build the chips with (makes building locally easier, no need to rebuild svd2rust-regress)
Add support for --chip XXX YYY
Added validators to chip, manufacturer and architecture
-vv will now output all stderr logs
Added --list to quickly troubleshoot what test cases will be run
A patched ATSAMD21G18A svd, thanks to @wez

Open "issues"

Should we ignore case when filtering?
Should a --chip XXX always run even if it is set to only run on --long-test (and possibly --bad-test)
Add a -- command to pass arguments to svd2rust and possibly also a way to pass arguments to cargo check
Colorize output
Add regress:beta test to gitlab-runner
Move test cases to a or multiple config file(s) (e.g json/toml/yaml)

cc @jamesmunns

Also added `--list` to show what test cases would have been run using the current filters

errors

Also implements an alternate way to choose toolchain

jamesmunns · 2018-05-20T09:39:03Z

Hey @Emilgardis, ACKing this as seen, looks good overall, will have more time tomorrow (2018-05-21) to look at this.

I'd add one open issue: IMO It probably makes more sense to move all the test cases to one or more json/toml/yaml files rather than keeping it in code.

jamesmunns · 2018-05-21T23:52:03Z

ci/svd2rust-regress/src/svd_test.rs

 use std::io::prelude::*;
 use std::path::PathBuf;
 use std::process::{Command, Output};
 use tests::TestCase;

-static CRATES_ALL: &[&str] = &["bare-metal = \"0.1.0\"", "vcell = \"0.1.0\""];
+static CRATES_ALL: &[&str] = &["bare-metal = \"0.2.0\"", "vcell = \"0.1.0\""];


@Emilgardis is this info stored anywhere in svd2rust that we could use to prevent dual maintenance here?

The only place where this can be fetched from is the docs. We could also make svd2rust output $PWD/Cargo.toml needed via a flag

jamesmunns · 2018-05-21T23:54:00Z

Overall LGTM, if we can dedupe the dependent crates somehow, that would be nice, also feel free to open up one or more follow-up issues for the todos if you would like to go ahead and merge this.

Emilgardis · 2018-08-09T15:33:18Z

ci/svd2rust-regress/src/tests.rs

-        svd_url: None,
-        should_pass: false,
-        run_when: Never,
+        svd_url: Some("https://raw.githubusercontent.com/wez/atsamd21-rs/master/svd/ATSAMD21G18A.svd"),


This should be a specific commit

mathk · 2019-02-21T09:51:11Z

bors try

bors · 2019-02-21T09:51:12Z

🔒 Permission denied

Existing reviewers: click here to make mathk a reviewer

mathk · 2019-02-21T09:53:03Z

bors try

bors · 2019-02-21T09:53:05Z

try

Merge conflict

mathk · 2019-02-21T09:56:49Z

Ping from triage: @Emilgardis can you rebase/merge.

Disasm · 2019-03-16T16:51:10Z

@jamesmunns what is the current status of this PR? Does it need some discussion/changes or can it be merged right now?

therealprof · 2019-05-22T07:47:43Z

bors try

bors · 2019-05-22T09:16:39Z

try

Build succeeded

continuous-integration/travis-ci/push

therealprof

LGTM, let's land this and take it from there.

therealprof · 2019-05-22T09:22:53Z

bors r+

@wez

221: Improve ci r=therealprof a=Emilgardis This pr includes - Support for the changes done in v0.13 - `--toolchain foo` to specify what toolchain to build the chips with (makes building locally easier, no need to rebuild `svd2rust-regress`) - Add support for `--chip XXX YYY` - Added validators to chip, manufacturer and architecture - `-vv` will now output all stderr logs - Added `--list` to quickly troubleshoot what test cases will be run - A patched ATSAMD21G18A svd, thanks to @wez ## Open "issues" - Should we ignore case when filtering? - Should a `--chip XXX` always run even if it is set to only run on `--long-test` (and possibly `--bad-test`) - Add a `--` command to pass arguments to `svd2rust` and possibly also a way to pass arguments to `cargo check` - Colorize output - Add regress:beta test to gitlab-runner - Move test cases to a or multiple config file(s) (e.g json/toml/yaml) cc @jamesmunns Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com> Co-authored-by: Vadim Kaushan <admin@disasm.info>

bors · 2019-05-22T10:36:30Z

Build succeeded

continuous-integration/travis-ci/push

Emilgardis added 9 commits May 16, 2018 19:02

Added proper ATSAMD21G18A file, with alternateGroup already patched in

e9ba96d

Made chip a vec and added validators

4583956

Implemented more verbose logs

a02a3d6

Also added `--list` to show what test cases would have been run using the current filters

Added way to pass --nightly to svd2rust and changed logic for showing

d616795

errors

Changed validation error messages and added a "no tests run" message

d0fa4c6

Add nightly flag to gitlab runner

50e846a

Change the way -vv works, doesn't allocate all the time anymore

d6a1f53

Update to be compatible with v0.13.0

82d2fc5

Also implements an alternate way to choose toolchain

Fix -vv* not showing full output on fails

0b03132

Emilgardis requested a review from jamesmunns May 17, 2018 12:32

jamesmunns reviewed May 21, 2018

View reviewed changes

jamesmunns previously approved these changes May 21, 2018

View reviewed changes

Emilgardis commented Aug 9, 2018

View reviewed changes

Emilgardis mentioned this pull request Nov 18, 2018

Squashed commit implementing Feature Flags #254

Closed

mathk added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. labels Feb 21, 2019

Merge branch 'master' into improve-ci

e6cefa5

Disasm dismissed jamesmunns’s stale review via e6cefa5 March 16, 2019 16:46

Disasm requested a review from a team as a code owner March 16, 2019 16:46

bors bot added a commit that referenced this pull request May 22, 2019

Try #221:

519705e

therealprof approved these changes May 22, 2019

View reviewed changes

bors bot merged commit e6cefa5 into rust-embedded:master May 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve ci #221

Improve ci #221

Emilgardis commented May 17, 2018 •

edited

Loading

jamesmunns commented May 20, 2018

jamesmunns May 21, 2018

Emilgardis May 22, 2018

jamesmunns commented May 21, 2018

Emilgardis Aug 9, 2018

mathk commented Feb 21, 2019

bors bot commented Feb 21, 2019

mathk commented Feb 21, 2019

bors bot commented Feb 21, 2019

mathk commented Feb 21, 2019

Disasm commented Mar 16, 2019

therealprof commented May 22, 2019

bors bot commented May 22, 2019

therealprof left a comment

therealprof commented May 22, 2019

bors bot commented May 22, 2019

Improve ci #221

Improve ci #221

Conversation

Emilgardis commented May 17, 2018 • edited Loading

Open "issues"

jamesmunns commented May 20, 2018

jamesmunns May 21, 2018

Choose a reason for hiding this comment

Emilgardis May 22, 2018

Choose a reason for hiding this comment

jamesmunns commented May 21, 2018

Emilgardis Aug 9, 2018

Choose a reason for hiding this comment

mathk commented Feb 21, 2019

bors bot commented Feb 21, 2019

mathk commented Feb 21, 2019

bors bot commented Feb 21, 2019

try

Merge conflict

mathk commented Feb 21, 2019

Disasm commented Mar 16, 2019

therealprof commented May 22, 2019

bors bot commented May 22, 2019

try

Build succeeded

therealprof left a comment

Choose a reason for hiding this comment

therealprof commented May 22, 2019

bors bot commented May 22, 2019

Build succeeded

Emilgardis commented May 17, 2018 •

edited

Loading