-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a logging system. #237
Conversation
bors try |
tryBuild failed |
I think that might be an issue in the |
Hmm, it does look like it is somewhere there, I'm unfortunately not knowledgeable enough about macros to fix it, but I think I've tracked down the problem. Also, thanks for opening the PR! Travis Error when running
extern crate cortex_m_rt_macros as macros;
...
pub use macros::{entry, exception, pre_init}; I have reproduced the issue on my machine using The issue does not seem occur with @japaric does this seem like a reasonable conclusion / do you have any suggestions on how to fix it? |
|
bors try |
tryMerge conflict |
@achan1989 can you do a rebase/merge? Thanks |
@achan1989 Sorry for the long delay. Are you still interested in this? If so would you please update the PR? |
Oops. It's been a while, but I'll try to update. |
svd2rust now uses env_logger instead of printing directly to stderr. env_logger is currently configured to log messages >= info to stderr.
bors try |
🔒 Permission denied Existing reviewers: click here to make achan1989 a reviewer |
bors try |
tryBuild succeeded |
bors r+ |
237: Introduce a logging system. r=ryankurte a=achan1989 This pull request makes progress on #183. I've replaced the existing print/eprint calls with the appropriate logging macros, and arbitrarily chose env_logger to handle the logging. This should be functionally identical to the branch point, although the format of the logging output is different -- it's now of the form `<SEVERITY> svd2rust: <message>`. Co-authored-by: achan1989 <achan1989@gmail.com>
Build succeeded |
This pull request makes progress on #183.
I've replaced the existing print/eprint calls with the appropriate logging macros, and arbitrarily chose env_logger to handle the logging.
This should be functionally identical to the branch point, although the format of the logging output is different -- it's now of the form
<SEVERITY> svd2rust: <message>
.