Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only export Interrupt as interrupt when 'rt' is enabled #261

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Only export Interrupt as interrupt when 'rt' is enabled #261

merged 1 commit into from
Nov 27, 2018

Conversation

rnestler
Copy link
Contributor

It only makes sense to export interrupt if the interrupt! macro is
exported as well, since it's the only thing using it.
Fixes #260

@rnestler
Only export Interrupt as interrupt when 'rt' is enabled
93b6081 
It only makes sense to export interrupt if the interrupt! macro is
exported as well, since it's the only thing using it.
@rnestler rnestler requested a review from a team as a code owner November 27, 2018 09:26
@rnestler
Copy link
Contributor Author

@japaric

japaric
japaric approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors r+

bors bot added a commit that referenced this pull request Nov 27, 2018
@bors @rnestler
Merge #261
41f1908 
261: Only export Interrupt as interrupt when 'rt' is enabled r=japaric a=rnestler

It only makes sense to export interrupt if the interrupt! macro is
exported as well, since it's the only thing using it.
Fixes #260 

Co-authored-by: Raphael Nestler <raphael.nestler@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 27, 2018

Build succeeded

@bors bors bot merged commit 93b6081 into rust-embedded:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnestler @japaric