Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate documentation for the interrupt macro #284

Merged
merged 1 commit into from
Mar 3, 2019
Merged

Generate documentation for the interrupt macro #284

merged 1 commit into from
Mar 3, 2019

Conversation

Disasm
Copy link
Member

@Disasm Disasm commented Feb 13, 2019

Closes #280

@Disasm Disasm requested a review from a team as a code owner February 13, 2019 21:27
@Disasm
Copy link
Member Author

Disasm commented Feb 14, 2019

r? @therealprof

@Disasm Disasm mentioned this pull request Feb 15, 2019
Closed
@mathk mathk added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2019
@Disasm
Copy link
Member Author

Disasm commented Mar 3, 2019

Ping from triage: @therealprof, could you review this?

therealprof
therealprof approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof therealprof merged commit 323e22a into rust-embedded:master Mar 3, 2019
@Disasm Disasm deleted the add-docs-for-interrupt branch March 3, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Disasm @therealprof @mathk