Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing release tags links #286

Merged
merged 1 commit into from
May 22, 2019
Merged

Add missing release tags links #286

merged 1 commit into from
May 22, 2019

Conversation

therealprof
Copy link
Contributor

@therealprof therealprof requested a review from a team as a code owner March 12, 2019 19:42
@rust-highfive
Copy link

@therealprof: no appropriate reviewer found, use r? to override

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Mar 12, 2019
@therealprof
Copy link
Contributor Author

r? @ryankurte

ryankurte
ryankurte approved these changes Mar 13, 2019
View reviewed changes
Copy link

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing them!

@ryankurte
Copy link

bots r+

@mathk mathk added S-waiting-on-bors Status: Waiting on bors to run and complete tests. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2019
@mathk
Copy link

mathk commented Apr 10, 2019

bors try

bors bot added a commit that referenced this pull request Apr 10, 2019
@bors
Try #286:
4123c60
@mathk
Copy link

mathk commented Apr 10, 2019

@ryankurte I guess there is a typo in your comment.

@therealprof
Copy link
Contributor Author

bors r=ryankurte

bors bot added a commit that referenced this pull request Apr 10, 2019
@bors @therealprof
Merge #286
ce16447 
286: Add missing release tags links r=ryankurte a=therealprof

... also changed https://github.com/japaric -> https://github.com/rust-embedded

Co-authored-by: Daniel Egger <daniel@eggers-club.de>
@mathk
Copy link

mathk commented Apr 10, 2019

@therealprof Thanks I just learn a command ;)

@rust-embedded rust-embedded deleted a comment from bors bot Apr 10, 2019
@bors
Copy link
Contributor

bors bot commented Apr 10, 2019

try

Build failed

@bors
Copy link
Contributor

bors bot commented Apr 10, 2019

Build failed

@ryankurte
Copy link

ryankurte commented Apr 10, 2019 •
edited
Loading

bots r+

whoops 😅

CI error on nightly, which is completely unrelated to this PR.

error: failed to run custom build command for `svd2rust v0.14.0 (/project)`
process didn't exit successfully: `/target/debug/build/svd2rust-c4fd4d7869ba4206/build-script-build` (exit code: 1)
--- stderr
/target/debug/build/svd2rust-c4fd4d7869ba4206/build-script-build: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.18' not found (required by /target/debug/build/svd2rust-c4fd4d7869ba4206/build-script-build)
warning: build failed, waiting for other jobs to finish...
error: build failed
The command "bash ci/script.sh" exited with 101.

@therealprof seems fine to manual merge if you can / would like.

@therealprof therealprof merged commit 16c00cc into master May 22, 2019
@bors bors bot deleted the release-tags-links branch May 22, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankurte ryankurte ryankurte approved these changes

Assignees

@ryankurte ryankurte

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@therealprof @rust-highfive @ryankurte @mathk