Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump svd v0.7, rm ref #300

Closed
wants to merge 1 commit into from
Closed

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jun 1, 2019

bump svd-parser to v0.7, rm ref in match patterns without changing functionality

@burrbull burrbull requested a review from a team as a code owner June 1, 2019 07:48
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Emilgardis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jun 1, 2019
@@ -76,7 +71,7 @@ fn run() -> Result<()> {
}
}

let device = svd::parse(xml);
let device = svd::parse(xml).unwrap();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to convert Error here.

@Emilgardis
Copy link
Member

Thanks for the pr!

This is a duplicate of #256, if you did a pr to register-derived-from fixing merge conflicts I would be happy to approve that :)

@Emilgardis Emilgardis closed this Jun 1, 2019
@burrbull burrbull deleted the svd07 branch July 12, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants