Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some noise in the generated code #302

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Remove some noise in the generated code #302

merged 1 commit into from
Jul 2, 2019

Conversation

therealprof
Copy link
Contributor

Struct initialisations don't need to repeat field names if they're equal
to a local variable.

Signed-off-by: Daniel Egger daniel@eggers-club.de

@therealprof
Remove some noise in the generated code
9f2efee 
Struct initialisations don't need to repeat field names if they're equal
to a local variable.

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
@therealprof therealprof requested a review from a team as a code owner July 2, 2019 11:23
@rust-highfive
Copy link

r? @Emilgardis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 2, 2019
Emilgardis
Emilgardis approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

bors bot added a commit that referenced this pull request Jul 2, 2019
@bors @therealprof
Merge #302
dfc4d5b 
302: Remove some noise in the generated code r=Emilgardis a=therealprof

Struct initialisations don't need to repeat field names if they're equal
to a local variable.

Signed-off-by: Daniel Egger <daniel@eggers-club.de>

Co-authored-by: Daniel Egger <daniel@eggers-club.de>
@bors
Copy link
Contributor

bors bot commented Jul 2, 2019

Build succeeded

@bors bors bot merged commit 9f2efee into master Jul 2, 2019
@bors bors bot deleted the branches/remove-struct-init-noise branch July 2, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees

@Emilgardis Emilgardis

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@therealprof @rust-highfive @Emilgardis