Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use svd-parser 0.7 and Edition 2018 #317

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Use svd-parser 0.7 and Edition 2018 #317

merged 2 commits into from
Jul 19, 2019

Conversation

burrbull
Copy link
Member

Use 2 last commits from #256 :
b6d2c9a and b7965db

cc @therealprof

@burrbull burrbull requested a review from a team as a code owner July 19, 2019 10:47
@rust-highfive
Copy link

r? @therealprof

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 19, 2019
@burrbull
Copy link
Member Author

изображение

@therealprof
Copy link
Contributor

Interesting, completely missed that... Will take a look now.

therealprof
therealprof approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jul 19, 2019
@bors @burrbull
Merge #317
0bc1480 
317: Use svd-parser 0.7 and Edition 2018 r=therealprof a=burrbull

Use 2 last commits from #256 :
b6d2c9a and b7965db

cc @therealprof 

Co-authored-by: James Munns <james.munns@ferrous-systems.com>
Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 19, 2019

Build succeeded

@bors bors bot merged commit e74ecbd into rust-embedded:master Jul 19, 2019
@burrbull burrbull deleted the svd007 branch July 19, 2019 16:30
@burrbull burrbull mentioned this pull request Jul 19, 2019
Closed
This was referenced Jul 26, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @rust-highfive @therealprof