Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum usage + expand_properties #111

Merged
merged 5 commits into from
May 15, 2022
Merged

enum usage + expand_properties #111

merged 5 commits into from
May 15, 2022

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented May 13, 2022 •
edited
Loading

Closes #110 for rust svdtools version

Require stm32-rs/stm32-rs#734

@burrbull burrbull force-pushed the usage branch 3 times, most recently from b795e98 to 2c62444 Compare May 14, 2022 04:56
@burrbull burrbull marked this pull request as ready for review May 14, 2022 15:47
@burrbull burrbull force-pushed the usage branch 4 times, most recently from 651ddc7 to a55a108 Compare May 15, 2022 05:30
adamgreig
adamgreig approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I guess let's leave #110 open until Python version is fixed and this TODO is done?

bors r+

@burrbull
Copy link
Member Author

Thanks. I guess let's leave #110 open until Python version is fixed and this TODO is done?

Yes

@bors
Copy link
Contributor

bors bot commented May 15, 2022

Build succeeded:

@bors bors bot merged commit 2b330c9 into master May 15, 2022
@bors bors bot deleted the usage branch May 15, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enum usage always read-write if not specified
2 participants
@burrbull @adamgreig