Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v17.2.0 #277

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Release v17.2.0 #277

merged 1 commit into from
Aug 15, 2022

Conversation

shekhirin
Copy link
Contributor

No description provided.

@@ -1,6 +1,6 @@
[package]
name = "ethabi-cli"
version = "17.1.0"
version = "17.2.0"
Copy link
Contributor

@nlordell nlordell Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why not a revision version bump (so, 17.1.1) since its just a bug fix for nested tuple and array parsing?

Copy link
Contributor Author

@shekhirin shekhirin Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought that parsing nested arrays/tuples is a new feature rather than a bugfix, but i can change to patch bump if you'd like

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so familiar with the ethabi CLI tool, so I was just curious about the reasoning, not necessarily suggesting it should be one way or the other.

@vkgnosis vkgnosis merged commit ef9a62b into rust-ethereum:master Aug 15, 2022
@vkgnosis
Copy link
Member

I'll make the crates.io release.

@vkgnosis
Copy link
Member

Turns out nlordell and I are only owners of the main ethabi crate and not the other crates (ethabi-cli, ethabi-contract, ethabi-derive) so we can't release those.

@vkgnosis
Copy link
Member

Since it's a binary crate maybe ethabi-cli doesn't need to be on crates.io anyway? You could use it from git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants