Disable dead stripping #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it, some optimized targets would fail to launch with the following error: ERROR: The size of coverage PC tables does not match the number of instrumented PCs. This might be a compiler bug, please contact the libFuzzer developers. Also check https://bugs.llvm.org/show_bug.cgi?id=34636 for possible workarounds (tl;dr: don't use the old GNU ld) Related to: - google/oss-fuzz#1042 - llvm.org/pr34636
|
The build is currently broken due to rust-lang/rust#66140. The same failure is on master as well. I assume that the pipeline will be fixed once rust-lang/rust#65241 makes it to the nightly build. Once that's the case, we should try re-running the pipeline on this PR to make sure it's passing. |
|
We can manually merge this, this seems harmless enough and fixes an important issue. |
This was referenced Nov 22, 2019
ghedo
pushed a commit
to cloudflare/quiche
that referenced
this pull request
Nov 25, 2019
Optimizations significantly inscreases fuzzing speed. This requires cargo-fuzz 0.5.5+. See rust-fuzz/cargo-fuzz#193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With dead stripping, some optimized targets would fail to start fuzzing with the following error:
If you'd like to reproduce the issue, clone https://github.com/cloudflare/quiche and run
cargo fuzz run packet_recv_client --releasefrom the fuzz directory. You should see the above error.This PR disables dead stripping, which removes the above error. Alternatively, one could use ld.gold by adding
-Clink-arg=-fuse-ld=goldto RUSTFLAGS. This would also fix the error. However, I did not want to assume that ld.gold was present on users' systems. Others have also successfully switched to disabling dead stripping, like OSS-Fuzz, so it seemed like a better solution.Environment
cargo-fuzz 0.5.4
cargo 1.41.0-nightly (8280633db 2019-11-11)
rustc 1.41.0-nightly (3e525e3f6 2019-11-18)
Debian bullseye container running on Mac OS 10.15.1 and Docker Desktop 2.1.0.5