Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N17: Dotrix #441

Closed
wants to merge 1 commit into from
Closed

N17: Dotrix #441

wants to merge 1 commit into from

Conversation

voxelias
Copy link
Contributor

@voxelias voxelias commented Jan 8, 2021

@ozkriff ozkriff mentioned this pull request Jan 8, 2021
Closed
@ozkriff
Copy link
Member

ozkriff commented Jan 13, 2021

Make sure that the "Allow edits from maintainers" box is checked (avoid using org accounts if possible) - it makes updating/tweaking the PR easier for the coordinators.

Thanks for the PR! Made a few style & fmt tweaks, rebased and merged manually in a5f69a6 (as the branch is not allowed for maintainers to edit).

@ozkriff ozkriff closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voxelias @ozkriff @17cupsofcoffee