partition_map: loosened Fn to FnMut; replaced for by for_each
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 31, 2019
366: partition_map: loosened Fn to FnMut; replaced `for` by `for_each` r=jswrenn a=danielhenrymantilla - the `Fn` bound was not necessary; - `.for_each` and internal iteration can be more efficient than `for` loops with, for instance, `.chain`ed iterators. Co-authored-by: Daniel Henry-Mantilla <daniel.henry.mantilla@gmail.com>
Build succeeded |
Merged
|
When will the new version be released with this fix? :) |
|
@Boscop I'll try to publish to crates.io sometime in the next few weeks. The only real obstacle is the bookkeeping work of updating the changelog in the README. I've unfortunately had my hands full with preparing for my dissertation proposal. (However, I'd be delighted to receive a PR updating the changelog.) |
Merged
bors bot
added a commit
that referenced
this pull request
Oct 27, 2019
376: 0.8.1 release r=jswrenn a=danielhenrymantilla Updated Changelog and `Cargo.toml` for the ~~0.9.0~~ 0.8.1 release, as suggested in #366 (comment) - [Rendered](https://github.com/rust-itertools/itertools/blob/a7a1203960451fe2ba21394e5b38981ef8323181/README.rst) Co-authored-by: Daniel Henry-Mantilla <daniel.henry.mantilla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
Fnbound was not necessary;.for_eachand internal iteration can be more efficient thanforloops with, for instance,.chained iterators.