Create CONTRIBUTING.md
#767
Conversation
There is no point in running CI only for markdown changes. Such as rust-itertools#802 (prepare releases) and rust-itertools#767 (Contributing.md) https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore
There is no point in running CI only for markdown changes. Such as #802 (prepare releases) and #767 (Contributing.md) https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore
Philippe-Cholet
force-pushed
the
contributing
branch
2 times, most recently
from
6dcdd9d to
91305b4
Compare
Philippe-Cholet
force-pushed
the
contributing
branch
from
91305b4 to
8d4e042
Compare
|
I finally mentionned tests and benchmarks. |
|
Mark this 'ready for review' whenever you feel it's ready to be merged! |
Philippe-Cholet
force-pushed
the
contributing
branch
from
1aa39cf to
5fe6223
Compare
|
I squashed my commits, I think it's a decent initial CI is blocked since #805. I'm not sure what to do apart from removing the |
|
Oh, huh. That's a funny situation. I think we can fix this by adding a no-op job that always succeeds, and have |
Philippe-Cholet
force-pushed
the
contributing
branch
from
362669e to
5fe6223
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #767 +/- ##
=======================================
Coverage 94.38% 94.38%
=======================================
Files 48 48
Lines 6665 6665
=======================================
Hits 6291 6291
Misses 374 374 ☔ View full report in Codecov by Sentry. |
|
Hm, never mind. That won't help. Honestly, it might just be easiest for me to bypass branch protections for these cases. |
Fixes #756
As mentioned in the issue, I did not write anything related to testing yet, as I think we should clarify what's expected of contributors.
Rendered here