Make Combinations lazy
#795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the `Combinations` adaptor lazy, the operation "prefill the lazy buffer" is now done when handling the first element rather than at definition. However, the value returned by the `n` method is changed when called on a fresh `it.combinations(k)` since the "prefill" operation was delayed. I'm perplex on why the method `n` was made public in the first place as the value is subject to change (said in its documentation). But it is public and this change is therefore a breaking one.
Philippe-Cholet
force-pushed
the
combinations-laziness
branch
from
fb1bc1f to
247dd5b
Compare
jswrenn
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Having given this a few days of thought, I don't think this qualifies as a breaking change. Yes, the observable behavior changes. But that's also true even without this method, and we haven't been considering our other lazy-ification efforts to be breaking changes (rather, they're really bugfixes).
This was referenced Nov 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #792
To make the
Combinationsadaptor lazy, the operation "prefill the lazy buffer" is now done when handling the first element rather than at definition.However, the value returned by the
nmethod is changed when called on a freshit.combinations(k)since the "prefill" operation was delayed. I'm perplex on why the methodnwas made public in the first place as the value is subject to change (said in its documentation). But it is public and this change is therefore a (small) breaking one, right?