Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_specializations
need clonable iterators which helped find iterators that should be clonable but were not yet. 3 very small commits.Now about mostly done... Not all of our iterators are tested here:
group_by
chunks
tee
rciter
test_specializations
need clonable iterators but&mut iterator
is not clonable, Therefore, we can't clonePeekingTakeWhile
andTakeWhileRef
. We need to find a way to test them too.Finally a bug...
multi_cartesian_product
is not tested here because specializations oflast
andcount
FAIL sometimes, and I don't want this pull request to be blocked by it! It requires further investigation and will have a dedicated pull request.EDIT: Apparently, the iterator is not fused even when all child iterators are, and this was the intended behavior, that's confusing.
Later EDITs: While making a bunch of specialization benchmarks, I noticed that I forgot some and some here:
repeat_n
TupleBuffer
(buffer for a finished.tuples()
)MapForGrouping
used forGroupingMapBy
but it's strictly internal to the library, a method ofGroupingMapBy
should be tested to test the specialization of futureMapForGrouping::fold
.unfold
,iterate
: infinite iterators so e.g. testlast
would not finish.