allow small variation in coverage without returning a failure #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #856 +/- ##
==========================================
- Coverage 93.44% 93.43% -0.02%
==========================================
Files 48 48
Lines 6774 6774
==========================================
- Hits 6330 6329 -1
- Misses 444 445 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The content of the file seems good to me.
I've seen use of codecov.yml but yours is .codecov.yml, is it sensible?
EDIT: It's okay. https://docs.codecov.com/docs/codecov-yaml#can-i-name-the-file-codecovyml
Philippe-Cholet
approved these changes
Jan 19, 2024
|
For future readers, it's the same as PyO3/pyo3#1142. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.